Skip to content

Conversation

ChuyueSun
Copy link
Contributor

@ChuyueSun ChuyueSun commented Feb 7, 2025

Motivation

OpenAI API o1 model does not support max_tokens. It uses max_completion_tokens instead.

Modifications

  • Add openai API support for o1.
  • Add an example script.

Checklist

  • Format your code according to the Code Formatting with Pre-Commit.
  • Add unit tests as outlined in the Running Unit Tests.
  • Update documentation / docstrings / example tutorials as needed, according to Writing Documentation.
  • Provide throughput / latency benchmark results and accuracy evaluation results as needed, according to Benchmark and Profiling and Accuracy Results.
  • For reviewers: If you haven't made any contributions to this PR and are only assisting with merging the main branch, please remove yourself as a co-author when merging the PR.

@zhyncs zhyncs merged commit 6cc3095 into sgl-project:main Feb 14, 2025
16 of 19 checks passed
@zhyncs
Copy link
Member

zhyncs commented Feb 14, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants