ROCm: sgl-kernel enablement starting with sgl_moe_align_block #3287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhyncs
reviewed
Feb 4, 2025
| if is_cuda: | ||
| from sgl_kernel import moe_align_block_size as sgl_moe_align_block_size | ||
|
|
||
| from sgl_kernel import moe_align_block_size as sgl_moe_align_block_size |
There was a problem hiding this comment.
Add is_cuda or is_hip here, we shouldn't disrupt other devices (such as xpu, hpu, etc.).
There was a problem hiding this comment.
Let's make though this one (code followed previous), I will add that in follow up, sounds good?
zhyncs
reviewed
Feb 4, 2025
|
|
||
| sources = [ | ||
| "src/sgl-kernel/torch_extension_rocm.cc", | ||
| "src/sgl-kernel/csrc/moe_align_kernel.cu", |
There was a problem hiding this comment.
Do you need to update this for ROCm?
sglang/sgl-kernel/src/sgl-kernel/csrc/moe_align_kernel.cu
Lines 27 to 28 in 70817a7
There was a problem hiding this comment.
Not this moment, works now. We will do deeper custom later.
There was a problem hiding this comment.
ok I just remember to remove the ROCm-related code earlier.
There was a problem hiding this comment.
@zhyncs created 2 issues to work on asap, thx.
zhyncs
approved these changes
Feb 4, 2025
9 tasks
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
As they are.
Checklist