Skip to content

Conversation

simveit
Copy link
Contributor

@simveit simveit commented Feb 2, 2025

Motivation

This PR intends to update the docs on sampling parameters as suggested here

Modifications

New docs for sampling params

Checklist

Copy link
Collaborator

@shuaills shuaills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@zhaochenyang20
Copy link
Collaborator

@simveit Should this be ready?

@simveit
Copy link
Contributor Author

simveit commented Feb 16, 2025

@zhaochenyang20 IMO yes.
what do you think @shuaills ?

@zhaochenyang20
Copy link
Collaborator

If so, turn ready to review, thanks!

@simveit simveit marked this pull request as ready for review February 16, 2025 18:48
Copy link
Collaborator

@shuaills shuaills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@zhaochenyang20 zhaochenyang20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G reat job @shuaills @simveit

@zhaochenyang20 zhaochenyang20 merged commit 8f13377 into sgl-project:main Feb 16, 2025
12 checks passed
@simveit simveit deleted the feature/sampling-params branch February 17, 2025 19:07
},
stream=True,
)
If you want a high-level endpoint that can automatically handle chat templates, consider using the [OpenAI Compatible API](https://docs.sglang.ai/backend/openai_api_completions.html).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simveit @zhaochenyang20 please always use relative links.
This link should be [OpenAI Compatible API](../backend/openai_api_completions.ipynb)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants