Skip to content

Fix draft decode max batch size #3676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

Fix draft decode max batch size #3676

merged 1 commit into from
Feb 18, 2025

Conversation

ispobock
Copy link
Collaborator

@ispobock ispobock commented Feb 18, 2025 •
edited
Loading

Motivation

For draft decode in spec, the max batch size should be req_to_token_pool.size*topk.

@ispobock
Copy link
Collaborator Author

cc: @Ying1123

@zhyncs zhyncs merged commit e5ce395 into sgl-project:main Feb 18, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merrymercy merrymercy Awaiting requested review from merrymercy merrymercy is a code owner

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@zhyncs zhyncs Awaiting requested review from zhyncs zhyncs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ispobock @zhyncs