Skip to content

Conversation

shuaills
Copy link
Collaborator

@shuaills shuaills commented Feb 16, 2025

Motivation

This PR fixes multi-user port allocation conflicts by using a global lock mechanism. Previously, per-user locks led to race conditions when reserving ports. Now, we use socket to do this.

Modifications

Checklist

@shuaills shuaills changed the title [fix ] Fix Multi-User Port Allocation Conflicts [WIP] Fix Multi-User Port Allocation Conflicts Feb 16, 2025
@shuaills shuaills changed the title [WIP] Fix Multi-User Port Allocation Conflicts [Improve] Fix Multi-User Port Allocation Conflicts Feb 19, 2025
Copy link
Collaborator

@zhaochenyang20 zhaochenyang20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Why delete this>?

@zhaochenyang20
Copy link
Collaborator

I will give credit to @simveit simp.veitner@gmail.com

@zhaochenyang20 zhaochenyang20 merged commit 55de40f into sgl-project:main Feb 19, 2025
17 of 19 checks passed
@shuaills shuaills deleted the fix/lockfile branch February 19, 2025 19:55
@simveit simveit mentioned this pull request Feb 25, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants