Skip to content

Simplify stream_output #2398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Dec 8, 2024
Merged

Simplify stream_output #2398

merged 19 commits into from
Dec 8, 2024

Conversation

merrymercy
Copy link
Contributor

@merrymercy merrymercy commented Dec 8, 2024 •
edited
Loading

  • Flatten the tuple for logprobs. It makes zmq IPC faster. This is useful when using logprob + streaming.

@merrymercy merrymercy merged commit a6ca736 into main Dec 8, 2024
17 checks passed
@merrymercy merrymercy deleted the pr-fix-streaming branch December 8, 2024 20:27
timethink pushed a commit to timethink/sglang that referenced this pull request Mar 9, 2025
@merrymercy
Simplify stream_output (sgl-project#2398)
29ee0a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@hnyls2002 hnyls2002 Awaiting requested review from hnyls2002 hnyls2002 is a code owner

@zhyncs zhyncs Awaiting requested review from zhyncs zhyncs is a code owner

@ispobock ispobock Awaiting requested review from ispobock ispobock is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@merrymercy