Check gpu availability at server args creation #2340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ata Fatahi <immrata@gmail.com>
ByronHsu
reviewed
Dec 3, 2024
There was a problem hiding this comment.
LGTM to unblock our internal use. cc @merrymercy for the final stamp
zhyncs
approved these changes
Dec 4, 2024
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
Signed-off-by: Ata Fatahi <immrata@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
During server args construction we check the gpu memory size to configure knobs like chunked prefill and cuda graph sizes.
For use cases where the args are constructed programmatically on a non-GPU environment and sent to a GPU environment, this fails because we use
nvidia-smito check nv GPU memory size while it's not available in those environments.Modifications
Add a check for gpu availability before checking the memory size.
Checklist