Fix Docs CI When Compile Error #2323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merrymercy
requested changes
Dec 3, 2024
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I find that our current docs are broken in
native_api:https://sgl-project.github.io/backend/native_api.html
I changed the rules of docs CI. When one ipynb file fails to compile, the CI will end in error. And I changed
native_apifor a quick fix onupdate_weights_from_diskandencode(changerewardtoencode).Also, I will fix #2322 this week. This is not highly prioritized and I have some personal things this week. I think I will edit the
llama.pyin our models for a quick fix on this.Modifications
See this motivation above.
Checklist