Skip to content

Crash the server correctly during error #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 28, 2024
Merged

Crash the server correctly during error #2231

merged 7 commits into from
Nov 28, 2024

Conversation

merrymercy
Copy link
Contributor

@merrymercy merrymercy commented Nov 28, 2024 •
edited
Loading

  • Instead of using the old kill_parent_process, now it sends a SIGQUIT to the main process and try to recursively kill from there.
  • Rename kill_child_process to kill_process_tree

merrymercy
merrymercy commented Nov 28, 2024
View reviewed changes
@merrymercy merrymercy merged commit d4fc1a7 into main Nov 28, 2024
17 of 18 checks passed
@merrymercy merrymercy deleted the pr-fix-kill branch November 28, 2024 08:22
timethink pushed a commit to timethink/sglang that referenced this pull request Mar 9, 2025
@merrymercy
Crash the server correctly during error (sgl-project#2231)
a8fd96e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByronHsu ByronHsu Awaiting requested review from ByronHsu

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@zhyncs zhyncs Awaiting requested review from zhyncs zhyncs is a code owner

@hnyls2002 hnyls2002 Awaiting requested review from hnyls2002 hnyls2002 is a code owner

@ispobock ispobock Awaiting requested review from ispobock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@merrymercy