Update CI threshold #2186
Merged
Update CI threshold #2186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhyncs
reviewed
Nov 26, 2024
| @@ -36,7 +36,9 @@ def test_offline_throughput_non_stream_small_batch_size(self): | |||
| ) | |||
|
|
|||
| if is_in_ci(): | |||
| self.assertGreater(res["output_throughput"], 950) | |||
| # There is a regression with torch 2.5 | |||
There was a problem hiding this comment.
https://github.com/sgl-project/sglang/actions/runs/11997672042/job/33443552472
From this action run, it can be seen that torch 2.5.1 can also pass the threshold of 950, so the statement here is not accurate.
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.