Skip to content

[router] Replace print with logger #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 25, 2024
Merged

[router] Replace print with logger #2183

merged 5 commits into from
Nov 25, 2024

Conversation

ByronHsu
Copy link
Collaborator

Motivation

Modifications

Looks something like this

[Router (Python)] 2024-11-25 21:28:33 - INFO - Launching DP server process 0 on port 31000
[Router (Python)] 2024-11-25 21:28:33 - INFO - Launching DP server process 1 on port 31814
[Router (Rust)] 2024-11-25 21:29:40 - INFO - Tenant: http://127.0.0.1:31814, Size: 0
[Router (Rust)] 2024-11-25 21:29:40 - INFO - Tenant: http://127.0.0.1:31000, Size: 0
[Router (Rust)] 2024-11-25 21:29:40 - INFO - Processed Queue: {"http://127.0.0.1:31000": 0, "http://127.0.0.1:31814": 0}
[Router (Rust)] 2024-11-25 21:29:40 - INFO - Running Queue: {"http://127.0.0.1:31814": 0, "http://127.0.0.1:31000": 0}
[Router (Rust)] 2024-11-25 21:29:55 - INFO - Before eviction - Used size per tenant:
[Router (Rust)] 2024-11-25 21:29:55 - INFO - Tenant: http://127.0.0.1:31814, Size: 0

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@ByronHsu ByronHsu requested a review from Ying1123 as a code owner November 25, 2024 21:31
@ByronHsu ByronHsu merged commit 4d62bca into main Nov 25, 2024
5 checks passed
@ByronHsu ByronHsu deleted the byhsu/better-logging branch November 25, 2024 21:36
timethink pushed a commit to timethink/sglang that referenced this pull request Mar 9, 2025
@ByronHsu
[router] Replace print with logger (sgl-project#2183)
657b3fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ying1123 Ying1123 Awaiting requested review from Ying1123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ByronHsu