Merged three native APIs into one: get_server_info #2152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removing existing api routes can break existing users. Better to keep the old one and add |
|
I do not think they are ever used by any non-core developers, so we do not need to worry about the backward compatibility now. |
|
we actually use it, would love to get some warning about breaking changes in the future |
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Merged Native API endpoints
get_server_args,get_memory_pool_size, andget_max_num_tokensinto one endpoint:get_server_infofor cleaner code inserver.py.Modifications
Merged the three endpoints as mentioned above + Updated the docs/unittests accordingly.
Checklist