Skip to content

fix dp_rank env #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2024
Merged

fix dp_rank env #2144

merged 1 commit into from
Nov 23, 2024

Conversation

ByronHsu
Copy link
Collaborator

Motivation

Fix the issue

  File "/home/jobuser/resources/sglang/python/sglang/srt/managers/scheduler.py", line 1392, in run_scheduler_process
    dp_rank = int(os["DP_RANK"])
TypeError: 'module' object is not subscriptable

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@ByronHsu ByronHsu merged commit 52f58fc into sgl-project:main Nov 23, 2024
0 of 12 checks passed
timethink pushed a commit to timethink/sglang that referenced this pull request Mar 9, 2025
@ByronHsu
fix dp_rank env (sgl-project#2144)
5d74e69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merrymercy merrymercy Awaiting requested review from merrymercy merrymercy is a code owner

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@hnyls2002 hnyls2002 Awaiting requested review from hnyls2002 hnyls2002 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ByronHsu