Skip to content

Only stream output on tp rank 0 #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2024
Merged

Only stream output on tp rank 0 #2124

merged 1 commit into from
Nov 22, 2024

Conversation

merrymercy
Copy link
Contributor

No description provided.

@merrymercy merrymercy merged commit e1b6362 into main Nov 22, 2024
12 of 13 checks passed
@merrymercy merrymercy deleted the stream-output branch November 22, 2024 23:13
merrymercy added a commit that referenced this pull request Nov 22, 2024
@merrymercy
Revert "Only stream output on tp rank 0 (#2124)"
c3591ea 
This reverts commit e1b6362.
@merrymercy merrymercy mentioned this pull request Nov 22, 2024
Merged
timethink pushed a commit to timethink/sglang that referenced this pull request Mar 9, 2025
@merrymercy
Only stream output on tp rank 0 (sgl-project#2124)
8b44ecc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@hnyls2002 hnyls2002 Awaiting requested review from hnyls2002 hnyls2002 is a code owner

@zhyncs zhyncs Awaiting requested review from zhyncs zhyncs is a code owner

@ispobock ispobock Awaiting requested review from ispobock ispobock is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@merrymercy