Separate two entry points: Engine and HTTP server #2996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Co-authored-by: fzyzcjy <5236035+fzyzcjy@users.noreply.github.com>
c33ad77 to
b5c4682
Compare
3 tasks
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
Co-authored-by: fzyzcjy <5236035+fzyzcjy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to separate the Engine and HTTP server, so we can use the two entrypoints flexibly without depending on each other.
This PR splits the file
python/sglang/srt/server.pyinto the following two files:python/sglang/srt/entrypoints/engine.pypython/sglang/srt/entrypoints/http_server.py@app.api_route("/generate", methods=["POST", "PUT"]))The old
server.pyis deprecated now. This PR is based on #2959.