Refactor logprob computation to return the real logprob used in sampling #2664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0ae421 to
3820b70
Compare
2 tasks
3 tasks
XiaotongJiang
pushed a commit
to XiaotongJiang/sglang
that referenced
this pull request
Jan 3, 2025
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code computes the logprob of output tokens in
LogitsProcessor. However, this logprob can be different form the real logprob we used inSamplerbecause the logprob inLogitsProcessordoes not include temperature, top-p, or grammar mask.This PR fixes it by computing the logprob in
Sampler, so we unify the code path and make sure the logprob is the real logprob that we sample from.Closes #2178