Skip to content

Conversation

HaiShaw
Copy link
Collaborator

@HaiShaw HaiShaw commented Dec 30, 2024

Motivation

As it is

Modifications

Checklist

  • [+] Format your code according to the Contributor Guide.
  • [+] Add unit tests as outlined in the Contributor Guide.
  • [+] Update documentation as needed, including docstrings or example tutorials.

@zhyncs
Copy link
Member

zhyncs commented Dec 30, 2024

Please fix lint issue

@HaiShaw
Copy link
Collaborator Author

HaiShaw commented Dec 30, 2024

@merrymercy @zhyncs what is going on, lint failed on these 2 files, that I did not touch originally.

@merrymercy
Copy link
Contributor

rebase to the main, the buggy commit is reverted 3231817

@HaiShaw
Copy link
Collaborator Author

HaiShaw commented Dec 30, 2024

@merrymercy done.

@merrymercy merrymercy enabled auto-merge (squash) December 30, 2024 07:44
@merrymercy merrymercy disabled auto-merge December 30, 2024 07:44
@merrymercy merrymercy merged commit e6f523b into sgl-project:main Dec 30, 2024
1 of 14 checks passed
@HaiShaw HaiShaw deleted the typo_fix branch December 30, 2024 07:49
XiaotongJiang pushed a commit to XiaotongJiang/sglang that referenced this pull request Jan 3, 2025
timethink pushed a commit to timethink/sglang that referenced this pull request Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants