Update Triton configs for block fp8 kernels #2641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BBuf
reviewed
Jan 2, 2025
| @@ -418,8 +418,7 @@ def _distribute(method: str, inputs: List[Any]) -> List[Any]: | |||
| search_space = [ | |||
| config | |||
| for config in search_space | |||
| if block_n % config["BLOCK_SIZE_N"] == 0 | |||
There was a problem hiding this comment.
It seems. that the change would reduce the search space in normal cases, which might have a slight impact on fused_moe_triton performance.
There was a problem hiding this comment.
@BBuf Do you mean the removed line if block_n % config["BLOCK_SIZE_N"] == 0? I think it will make the search space larger after removing the line, as fewer limitations are required.
There was a problem hiding this comment.
if block_k % config["BLOCK_SIZE_K"] == 0 is required by the block w8a8 fp8 gemm. In the main loop of the gemm, this limitation can ensure that only a quantization scale is needed.
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Triton configs for block fp8 kernels