Skip to content

[FIX] Update EOS from config #2475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 27, 2024
Merged

[FIX] Update EOS from config #2475

merged 5 commits into from
Dec 27, 2024

Conversation

zhengy001
Copy link
Contributor

@zhengy001 zhengy001 commented Dec 13, 2024 •
edited
Loading

Motivation

Correct EOS as default tokenizer eos_token_id may different from model config eos_token_id

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@zhengy001 zhengy001 mentioned this pull request Dec 13, 2024
Closed
2 tasks
@zhengy001
Copy link
Contributor Author

Per @remixer-dec, model Mistral-Nemo-Instruct-2407-Q5_K_L.gguf has this issue.

merrymercy
merrymercy requested changes Dec 17, 2024
View reviewed changes
@zhengy001 zhengy001 requested a review from merrymercy December 19, 2024 09:26
merrymercy
merrymercy requested changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@merrymercy merrymercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some final comments!

@merrymercy merrymercy merged commit 7a7ac6b into sgl-project:main Dec 27, 2024
15 checks passed
timethink pushed a commit to timethink/sglang that referenced this pull request Mar 9, 2025
@zhengy001
[FIX] Update EOS from config (sgl-project#2475)
51e6eff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merrymercy merrymercy merrymercy requested changes

@hnyls2002 hnyls2002 Awaiting requested review from hnyls2002 hnyls2002 is a code owner

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@zhyncs zhyncs Awaiting requested review from zhyncs

@ispobock ispobock Awaiting requested review from ispobock

@ByronHsu ByronHsu Awaiting requested review from ByronHsu

Assignees
No one assigned
Labels
await-response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhengy001 @merrymercy