Skip to content

Fix group cutting behavior with CC triggered samples (such as sustain pedals) #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2021
Merged

Fix group cutting behavior with CC triggered samples (such as sustain pedals) #917

merged 3 commits into from
Jun 23, 2021

Conversation

praashie
Copy link
Contributor

@praashie praashie commented Jun 7, 2021

While trying out the Salamander Grand Piano, I noticed that the sustain pedal sample was not stopped upon releasing the pedal. The SFZ file does include an opcode for cutting the activation sample:

//======================
//pedalAction

<group> group=1 hikey=-1 lokey=-1 on_locc64=126 on_hicc64=127 off_by=2 volume=-20

<region> sample=samples/pedalD1.flac lorand=0 hirand=0.5
<region> sample=samples/pedalD2.flac lorand=0.5 hirand=1

<group> group=2 hikey=-1 lokey=-1 on_locc64=0 on_hicc64=1 volume=-19

<region> sample=samples/pedalU1.flac lorand=0 hirand=0.5
<region> sample=samples/pedalU2.flac lorand=0.5 hirand=1

This commit fixes this problem.

@paulfd
Copy link
Member

paulfd commented Jun 22, 2021

Thanks alot for the catch and the patch! I have removed the newline and added a test case.

@paulfd paulfd merged commit 3d6987d into sfztools:develop Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@praashie @paulfd