Thread-safety for receiving parameters #864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Curious about this, only an issue with carla vst3 hosting? |
|
I can't tell yet about Tracktion, I can give this a check. sfizz/plugins/vst/SfizzVstProcessor.cpp Lines 299 to 305 in 7ca9c15 |
2066c0f to
9580ca8
Compare
|
@falkTX confirmation that Tracktion Waveform has the problem too. Reaper does not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a thread-safety measure in the editor, because the Juce-based Carla host sends us the parameter updates in the wrong thread.
This regards the parameters changes of the level meters, performed by the DSP.
If this workaround is not implemented, this messes with the VSTGUI data, most likely the tracking of update rectangles, creating memory corruption.