-
-
Notifications
You must be signed in to change notification settings - Fork 69
Add support for count and loop_count #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9359ef3
to
f3f2206
Compare
ff65471
to
422e13d
Compare
I think the description on the original sfz v1 specs is a little ambiguous. |
@kinwie should be OK now ! |
@paulfd Tested the new build for this. The However, I encounter an issue for
After the loop, the snare will be cutoff. In Rapture and Sforzando, after the loop, it will play until the end of the sample. |
Okay I didn't know that, so I guess it's not over.
Loop sustain has a similar behavior right?
Feb 27, 2021 12:37:15 kinwie <notifications@github.com>:
… @paulfd[https://github.com/paulfd] Tested the new build for this. The count is fine now.
However, I encounter an issue for loop_count
The last portion of the sample after the loop is not played even I keep holding the key
Just in this simple example :
<region>
sample=snare_looped.wav
key=60
loop_count=3
After the loop, the snare will be cutoff. In Rapture and Sforzando, after the loop, it will play until the end of the sample.
Again, I know there is no detailed description for this opcode :))
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub[#654 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ADUFWQK6KEQZ5PHC5X7Z36TTBDKNFANCNFSM4YCJZUTQ].
[data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAYAAABXAvmHAAAABHNCSVQICAgIfAhkiAAAAB9JREFUaIHtwQEBAAAAgiD/r25IQAEAAAAAAAAAAC8GJDAAAY7rwGcAAAAASUVORK5CYII=###24x24:true###][Tracking image][https://github.com/notifications/beacon/ADUFWQNELJE55KMGULZCVEDTBDKNFA5CNFSM4YCJZUT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOF3UZF6Y.gif]
|
Yes, in loop_sustain, the last portion of the sample after the loop, will be played after releasing the key and it controlled by ampeg_release |
Okay so I revised all of this code to handle both the I distinguished 3 cases:
If there are loop points in the sample file and no I created a test file with a kick, a looping hi-hat and a crash to test stuff if various players if you like. |
I play your loop_count_test file in sforzando, DropZone and Rapture to compare to the current fix for loop_count. From your test file, the loop_sustain is already fine. Key e4 and g4 still not yet correct, imo, and I think the problem lies only at the So,
|
I've checked the "Fine tune the looping behavior" build. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK to merge if it works
Note that the
count
opcode apparently counts the number of restarts. It also setsloop_mode
toone_shot
.