Build a set of "effective" keyswitches and use that instead of sw_lokey/sw_hikey #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #423 #389
Also works towards #341 by letting the synth activate and deactivate regions as needed regarding keyswitches.
Still needs testing, all corner cases should go in the test suite. I will go through the official test suite to integrate as needed.
This reworks keyswitches overall.
sw_lokeyandsw_hikeyare now ignored more or less, and only effective keyswitches are taken into account forsw_last.sw_up,sw_down, andsw_previousare handled at the synth level too.sw_lolastandsw_hilast. If a label is given, the label is applied to all keys in the keyswitch range.