Skip to content

Add a mutex on the loading jobs to protect them in the case of freewheeling #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 15, 2020
Merged

Add a mutex on the loading jobs to protect them in the case of freewheeling #500

merged 4 commits into from
Oct 15, 2020

Conversation

paulfd
Copy link
Member

@paulfd paulfd commented Oct 15, 2020

Seemed to create alot of problems for ARM builds which hit the race condition all the time.

@paulfd paulfd requested a review from jpcima October 15, 2020 13:31
@jpcima
Copy link
Collaborator

jpcima commented Oct 15, 2020

Perhaps you forget this one as well

sfizz/src/sfizz/FilePool.cpp

Line 480 in a5647ab

loadingJobs.push_back(

@paulfd
Copy link
Member Author

paulfd commented Oct 15, 2020

I did, I moved it around at the last minute stupidly :)

@jpcima
Copy link
Collaborator

jpcima commented Oct 15, 2020

Use std::mutex? RT thread is not involved here

@paulfd paulfd merged commit 078fcf5 into sfztools:develop Oct 15, 2020
@paulfd paulfd deleted the loading-mutex branch October 15, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpcima jpcima jpcima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulfd @jpcima