Skip to content

accept samplesPerBlock up to 8192 (inclusive) #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2020
Merged

accept samplesPerBlock up to 8192 (inclusive) #484

merged 1 commit into from
Oct 7, 2020

Conversation

atsushieno
Copy link
Contributor

ASSERT(samplesPerBlock < config::maxBlockSize) (where maxBlockSize is 8192) means
we cannot set 8192. But we don't want 8191 as the actual maximum size.

@atsushieno
accept samplesPerBlock up to 8192 (inclusive)
b76a1c5 
`ASSERT(samplesPerBlock < config::maxBlockSize)` (where `maxBlockSize` is 8192) means 
we cannot set 8192. But we don't want 8191 as the actual maximum size.
@jpcima jpcima merged commit 0fb8abd into sfztools:develop Oct 7, 2020
@jpcima
Copy link
Collaborator

jpcima commented Oct 7, 2020

Thanks, I've also added your name to the list of contributors.

@atsushieno atsushieno deleted the patch-1 branch October 7, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atsushieno @jpcima