Set loop_mode to one_shot for release regions #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpcima
reviewed
Aug 19, 2020
src/sfizz/Region.cpp
Outdated
| break; | ||
| case hash("release_key"): | ||
| trigger = SfzTrigger::release_key; | ||
| loopMode = SfzLoopMode::one_shot; | ||
| break; |
There was a problem hiding this comment.
This behavior will not match to aria.
This is overriden by the loop_mode if present, regardless if happening before or after trigger.
For instance both of these will have loop_sustain.
<region> sample=sine440.wav pitch_keycenter=69 loop_mode=loop_sustain trigger=release_key
<region> sample=sine440.wav pitch_keycenter=69 trigger=release_key loop_mode=loop_sustain
There was a problem hiding this comment.
an loopmode is already an optional too! :)
ed38c93 to
66bdaaf
Compare
jpcima
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #372