Add a build helper for DPF #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Abseil seems to pull more deps under @pdesaulniers hi, possibly it interests you to check this work as well. |
paulfd
approved these changes
May 6, 2020
|
Btw, how come we pull in so many unrelated things from abseils? Like the time zone and synchronization primitives. I think we mostly use optional, span, the atoi-type helpers and a couple string functions here and there no? And the string_views.. |
|
I've included there the strict necessary set of libraries which is needed to please the linker, not one more. |
|
The question was more aimed at absl than your script 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a build helper for DPF plugins with sfizz.
There is an explanation how to use it at the top of the file.
@rghvdberg