Filter updates #199
Merged
Filter updates #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#198
This makes all biquad kinds very stable in presence of modulations.
For example,
brf2pwould easily have stability problems before. The new structure resolves this.It's a gain I introduced before to make SVF and Biquad match each other.
As it turned out, the SVF of Rapture don't bother to do this compensation, so I change it to conform.
Notes:
The
brf1pis still not much resistant to modulation, so it will need to rethink it.(or alias to
brf2p, the same as ARIA did)The SVF models also don't handle the modulation well at all, but I don't intent to tackle this problem soon.