Add support for Windows paths #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Windows paths (paths with backwards slashes as path separators). This makes it easier to use Ratchet on Windows machines.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Windows paths by normalizing file path inputs using filepath.Clean and filepath.ToSlash.
- Replace TrimPrefix with a robust Windows-friendly path cleaning mechanism.
- Improves cross-platform compatibility for file path resolution.
Comments suppressed due to low confidence (1)
command/command.go:155
- Ensure that unit tests cover cases with Windows-style paths containing backslashes to prevent regression issues.
pth = filepath.ToSlash(filepath.Clean(pth))
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Seth Vargo <seth@sethvargo.com>
|
Thanks for the super-quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Windows paths (paths with backwards slashes as path
separators).
This makes it easier to use Ratchet on Windows machines.