Replace "check" command with a full linter #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deprecates (and hides) the `check` command in favor of a new `lint` command that outputs more information about violations including filenames and specific line numbers.
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the deprecated "check" command with a new "lint" command that provides detailed output on unpinned version violations. Key changes include the addition of a new lint command and supporting linter and formatter packages, deprecation of the check command, and corresponding test and documentation updates.
- Introduced a new lint command in the command package.
- Deprecated the check command by adding deprecation messages and hiding it.
- Updated tests, documentation, and command generation code to reflect the change.
Reviewed Changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| command/lint.go | New lint command implementation replacing the check command. |
| formatter/formatter.go | New formatter implementations for various output formats. |
| linter/linter.go | New linter package containing the Violation type. |
| parser/parser.go | Refactored parser functions and integrated linting logic. |
| command/check.go | Deprecated the check command with appropriate deprecation notice. |
| main.go | Minor update to error output handling. |
| README.md | Updated documentation and usage examples to use lint instead of check. |
| command/cmd/gen/main.go | Simplified folder resolution in command generation. |
| parser/*_test.go | Updated expected test values from an empty slice to nil. |
| resolver/actions.go | Upgraded the GitHub API dependency version from v58 to v70. |
| command/command_gen.go | Updated generated command help to reference lint instead of check. |
| parser/refs.go | Simplified key extraction and cloning using maps and slices. |
| command/command.go | Added lint command to the command registry. |
Files not reviewed (1)
- go.mod: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Seth Vargo <seth@sethvargo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates (and hides) the
checkcommand in favor of a newlintcommand that outputs more information about violations including filenames and specific line numbers.Closes #103