Don't send sentry_timestamp in the header. #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I think I’d lean towards a PR that keeps sending the timestamp since in some situations that might be helpful information and different from when it was received by sentry (which is what I assume they default to if you don’t provide it). Would that work for you and would you be open to create a PR for that? |
|
Yeah that works for me! Here's the new version, sending the current time in UNIX format. |
|
FWIW, Sentry acknowledged this issue on their support forum. https://forum.sentry.io/t/string-formatted-timestamp-in-header-no-longer-accepted-by-api-breaking-clojure-raven-library/8383 |
|
Thanks, deployed with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
sentry_timestampin the header was sent in the format2019-12-13 12:02:58.94. This suddenly stopped working on 12/12 around 16:45 CST.Sentry's documentation (see the Authentication section) says that the
sentry_timestampshould be a UNIX timestamp. We tried sending0and that worked just fine, but we also tried not sendingsentry_timestampat all and that also worked.Here is a PR removing
sentry_timestampfrom the header. What do you think?