Skip to content

New option for livestream #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 15, 2016
Merged

New option for livestream #89

merged 6 commits into from
Feb 15, 2016

Conversation

davincho
Copy link

@davincho davincho commented Feb 7, 2016

As discussed in #52 it is now possible to use any arbitrary element or selector, like so:

quagga.init({
  inputStream : {
    name : "Live",
    type : "LiveStream",
    target: document.querySelector("#myelement")
  }
})

or

quagga.init({
  inputStream : {
    name : "Live",
    type : "LiveStream",
    target: "#myelement"
  }
})

serratus
serratus reviewed Feb 8, 2016
View reviewed changes
src/quagga.js
@@ -92,9 +106,9 @@ function ready(cb){
cb();
}

function initCanvas() {
function initCanvas(_config) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of passing in the _config parameter, you could also use the global one (see L51)

@serratus
Copy link
Owner

serratus commented Feb 8, 2016

Thanks for providing this PR. Works for me. Maybe you could drop one or two lines into the README to tell people how to use it (somewhere around https://github.com/serratus/quaggaJS#quaggainitconfig-callback).

serratus added a commit that referenced this pull request Feb 15, 2016
@serratus
Merge pull request #89 from davincho/master
e2226ed 
Option for specifying an entry point for the video-element.
@serratus serratus merged commit e2226ed into serratus:master Feb 15, 2016
@serratus
Copy link
Owner

Thanks for everything. Your changes will be made available in the next release which is scheduled in the next few days.

@serratus serratus mentioned this pull request Feb 15, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davincho @serratus