Enable .NET Native on AppVeyor + workaround on compiler error for #993 #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First pass reported incorrect |
- exit with non zero-code on error
|
LGTM; just one nit - could we call the UWP project Serilog.UwpTest, (UwpTests?) or, put it under sample/UwpDemo? The name jumps out at me as "an implementation of Serilog for UWP", otherwise. |
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically adds an empty UWP project (SDK = 10.0.10586) to the
testfolder and referencesSerilogto activate .NET Native on build. I didn't include this project to the solution to avoid tooling dependency. For the same reason build script was moved to a separate file. Not sure if its correct though.