Skip to content

Independent Build for Perf Tests. #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2017
Merged

Independent Build for Perf Tests. #978

merged 1 commit into from
Jun 4, 2017

Conversation

merbla
Copy link
Contributor

@merbla merbla commented Jun 2, 2017

Looking to setup an AppVeyor Build for Perf Tests here - https://ci.appveyor.com/project/serilog/serilog-jaske

@nblumhardt
Copy link
Member

Great idea; doesn't look like it's running the perf tests though, AFAICT from the output. Will we be able to do a perf run (even a limited one?) without timing out AppVeyor?

@merbla
Copy link
Contributor Author

merbla commented Jun 3, 2017

This is the output. Correct we may timeout, just wanted to try a few tweaks.

https://ci.appveyor.com/project/serilog/serilog-jaske/build/5

@nblumhardt
Copy link
Member

Thanks, not sure what I was looking at :-) ... merge ahoy!

@nblumhardt nblumhardt merged commit cfb1ef9 into serilog:dev Jun 4, 2017
@merbla
Copy link
Contributor Author

merbla commented Jun 4, 2017

@nblumhardt I was thinking we can try to reduce the TFM running in the tests. Are #IF defs significant enough across runtimes to warrant running on all targets?

@nblumhardt
Copy link
Member

I think it should only be running the latest .NET Core and .NET Framework (I could be wrong). Limiting the TFMs sounds good.

Looks like the results show the same problem running .NET Core benchmarks as I'm hitting locally:

https://ci.appveyor.com/project/serilog/serilog-jaske/build/5#L8703

// *** Execute ***
// Launch: 1 / 1
// Execute: C:\Users\appveyor\AppData\Local\Temp\1\3aa7825e-c71b-41da-8ecd-32f9fe3286c1\3aa7825e-c71b-41da-8ecd-32f9fe3286c1\assembly\dl3\4a80e9bf\61527e43_24dcd201\BDN.Generated.exe 
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.IO.FileNotFoundException: Could not load file or assembly 'BenchmarkDotNet.Core, Version=0.10.3.0, Culture=neutral, PublicKeyToken=aa0ca2f9092cefc4' or one of its dependencies. The system cannot find the file specified.
   at BenchmarkDotNet.Autogenerated.Runnable.Run(Boolean isDiagnoserAttached)
   --- End of inner exception stack trace ---
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)
   at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at BenchmarkDotNet.Autogenerated.Program.Main(String[] args)
ExitCode != 0
No more Benchmark runs will be launched as NO measurements were obtained from the previous run!
// ***** BenchmarkRunner: Finish  *****

I might try a BDN update to see if anything's changed.

@skomis-mm
Copy link
Contributor

@nblumhardt , try this. Will solve running on the full framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@merbla @nblumhardt @skomis-mm