Extend Support for Multi-Dimensional Arrays #2132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nblumhardt
reviewed
Oct 30, 2024
| @@ -317,6 +317,175 @@ public void NullMessageTemplateParametersDoNotBreakBinding() | |||
| // ReSharper restore StructuredMessageTemplateProblem | |||
| } | |||
|
|
|||
| // https://github.com/serilog/serilog/issues/2019 | |||
| [Fact] | |||
| public void Two_Dimensional_Array_Should_Be_Logger_As_Sequence() | |||
There was a problem hiding this comment.
Nit: _Should_Be_Logger => _Should_Be_Logged typo in this and several other of the test names.
Naming: tests in this project use PascalCase names, so TwoDimensionalArrayShouldBeLoggedAsSequence would be the matching casing here.
There was a problem hiding this comment.
Fixed Naming and Linting
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2019
developed based on #2035
To support multi dimensional arrays