Skip to content

Fall back to IDisposable in Log.CloseAndFlushAsync() when the target logger is not IAsyncDisposable #2116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 27, 2024
Merged

Fall back to IDisposable in Log.CloseAndFlushAsync() when the target logger is not IAsyncDisposable #2116

merged 3 commits into from
Sep 27, 2024

Conversation

nblumhardt
Copy link
Member

This fixes #2115.

We've missed spotting this previously because the default Logger type is IAsyncDisposable, and handles the fallback to IDisposable for sinks that don't implement it.

@nblumhardt nblumhardt merged commit 3aa295b into serilog:dev Sep 27, 2024
1 check passed
@nblumhardt nblumhardt mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CloseAndFlushAsync doesn't work with ReloadableLogger
1 participant
@nblumhardt