Removed boxing and string allocations in MessageTemplateTextFormatter #2094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alization for legacy (but still frequently used) MessageTemplateTextFormatter
|
Looks like a great change, left a comment on the other version of this PR which I think will also apply here: serilog/serilog-expressions#121 Cheers! |
…hods Original StringWriter.Write/WriteLine(ReadOnlySpan<char>) methods are optimized only for the StringWriter type itself, not derived classes. For derived classes, these methods copy the provided Span to an array from ArrayPool and fall back to Write(char[], int, int) method for backward compatibility with code created before the Span type existed. Explicit overrides in the ReusableStringWriter class that call StringBuilder.Append directly help to avoid the overhead of ArrayPool.Rent/Return and copying.
|
Thanks Evgeny! 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes allocations from legacy (but still not deprecated in Console/File sinks)
MessageTemplateTextFormatter. This may still be useful, since the timestamp is serialized for each log event.Allocations:
DateTimeOffsetboxing, by addingScalarValue.Render<T>overload with constraint forIFormattableDateTimeOffset.ToString()allocation, by usingISpanFormattable.TryFormatAPIOutputTemplateRenderingBenchmark.FormatToOutput
Before
After