Build updates for compatibility #2044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this isn't documented as strictly necessary, a problem arises where libraries or runtimes aren't available for the auto-generated BenchmarkDotNet assemblies, which results in warnings and errors failing the benchmarks. By adding the TFMs to the benchmark assembly, we'll get build errors/warnings up front about things that won't work. These were also upgraded because libraries like System.Diagnostics.DiagnosticSource throw warnings about not being supported or tested on older platforms like netcoreapp3.1.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were issues I had to fix to get Serilog building/testing on a Mac as part of the benchmarking for #1944.
.vscodefolder isn't a per-user setting the way.vsis..vscodeis how you provide a default build/test command for VS Code folks. I added that support so things like "Open Repo in VS Code" or other contributors can get going a little faster.Push-Locationat the start but neverPop-Location, so you'd end up with a stack of history entries. Added a try/finally so at the end - failure or success - it will still pop back to where you were.feature/xyzwith slashes. Added a fix for that so it'll replace slash with dash.SourceContextMatchBenchmarkfixture caused some problems due to the targeting specifically ofnetcoreapp2.1andnetcoreapp3.1. During the execution of the benchmarks, BenchmarkDotNet auto-generates an assembly that targets these frameworks so they can be run. This auto-generated assembly hasTreatWarningsAsErrorsturned on. In .NET 8, you get a NuGet warning when you try to targetnetcoreapp2.1becauseMicrosoft.NETCore.Appv2.1.0 has known security issues. All of this adds up to the auto-generated assembly not compiling and the benchmarks not running. Even if you get thenetcoreapp3.1building, you still get issues becauseSystem.Diagnostics.DiagnosticSourcewrites warnings about how it hasn't been tested and isn't supported againstnetcoreapp3.1. The fix for this is to:SourceContextMatchBenchmarkso you don't get the security warnings.I'm fine rolling any or all of this back, but this is what it took for me, on a Mac, to get this all working smoothly. Hopefully it can help other devs/contributors to get on board faster.