Created Logger should not hold reference to its configuration #1166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
reviewed
May 13, 2018
src/Serilog/LoggerConfiguration.cs
Outdated
| @@ -185,9 +179,18 @@ public Logger CreateLogger() | |||
| overrideMap = new LevelOverrideMap(_overrides, _minimumLevel, _levelSwitch); | |||
| } | |||
|
|
|||
| var disposableSinks = _logEventSinks.Concat(_auditSinks).OfType<IDisposable>().ToList(); | |||
There was a problem hiding this comment.
ToArray might be microscopically better?
There was a problem hiding this comment.
There is no reason to not making it microscopically better :) Done.
|
👍 good catch. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
Logger references to its configuration instance via
Disposeclosure that captures it.Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Other information:
After checking implications of introducing new state (
.WriteTo) forLoggerConfigurationin the neighboring pr found that currentCreateLogger()capturesLoggerConfigurationinstances.