Skip to content

Fix OSX/*nix build #1136 #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2018
Merged

Fix OSX/*nix build #1136 #1137

merged 3 commits into from
Mar 21, 2018

Conversation

merbla
Copy link
Contributor

@merbla merbla commented Mar 20, 2018

Details

  • Target netcoreapp2 for nix script
  • Ensure exit on error in build.sh

What issue does this PR address?

Does this PR introduce a breaking change?

  • No

Please check if the PR fulfills these requirements

  • The commit follows our guidelines
  • Unit Tests for the changes have been added (for bug fixes / features)

Other information:

adamchester
adamchester requested changes Mar 20, 2018
View reviewed changes
Copy link
Member

@adamchester adamchester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to interrupt here, maybe I jumped the gun approving :)

Looks like travis needs dotnet: 2.1.4 to match global.json SDK version?

@merbla merbla merged commit 4331b6b into serilog:dev Mar 21, 2018
@adamchester
Copy link
Member

🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamchester adamchester adamchester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merbla @adamchester