Implementation of #1006 #1007
Merged
Implementation of #1006 #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng enrichers especially in async context.
|
Great! Thanks, will take a look 👍 CC @serilog/reviewers-core. |
nblumhardt
reviewed
Jul 28, 2017
src/Serilog/Context/LogContext.cs
Outdated
| /// </summary> | ||
| public static void Reset() | ||
| { | ||
| var enrichers = GetOrCreateEnricherStack(); |
There was a problem hiding this comment.
It's not necessary to create the enricher stack here if it doesn't exist; we could use:
var enrichers = Enrichers;
if (enrichers != null && enrichers != ImmutableStack<ILogEventEnricher>.Empty)
Enrichers = ImmutableStack<ILogEventEnricher>.Empty;There was a problem hiding this comment.
Sure, that totally makes sense, will fix that.
|
@nblumhardt I have changed code according to your suggestions. Please take a look on it, when you have some time. |
|
Fantastic, thanks. Just made some very minor adjustments to the documentation wording; will merge once CI completes :-) |
Closed
|
👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is implementation of #1006
Add Suspend and Reset methods to LogContext to allow removing enrichers.
Add tests for Suspend and Reset methods.