Skip to content

Conversation

epeshk
Copy link
Contributor

@epeshk epeshk commented Aug 21, 2023

Related issue: #1946

@nblumhardt
Copy link
Member

How would the numbers come out if we ditched the fall-through to the by-value cache?

There's a good case to be made for reducing memory use by dropping the second dictionary; anyone who is formatting message "templates" dynamically is probably not actually using message templates and is likely to be generating unique strings anyway, so the situations that will actually benefit from the second layer of caching are pretty limited.

@epeshk
Copy link
Contributor Author

epeshk commented Oct 2, 2023

Yes, I agree that it's better to remove by-value cache completely

@nblumhardt
Copy link
Member

LGTM 👍

Interested whether anyone else can spot gotchas I might have missed so will leave this a few more days.

@nblumhardt nblumhardt merged commit 88f76a8 into serilog:dev Oct 9, 2023
@nblumhardt nblumhardt mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants