Skip to content

Accept/pass through the standard levelSwitch option in WriteTo.Logger() #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2023
Merged

Accept/pass through the standard levelSwitch option in WriteTo.Logger() #1902

merged 2 commits into from
May 3, 2023

Conversation

nblumhardt
Copy link
Member

This overload was introduced in #1890, so there's no compatibility concern here.

augustoproiete
augustoproiete approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nblumhardt nblumhardt merged commit 7a38acd into serilog:dev May 3, 2023
@SimonCropp
Copy link
Contributor

note that this is a breaking change

@nblumhardt
Copy link
Member Author

@SimonCropp in this case no, the signature being changed is a completely new one that's never appeared pre-3.0.

@SimonCropp
Copy link
Contributor

@nblumhardt ahhh. thanks for the correction

@nblumhardt nblumhardt mentioned this pull request Jun 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augustoproiete augustoproiete augustoproiete approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nblumhardt @SimonCropp @augustoproiete