Adding ability to dispose nested loggers in WriteTo.Logger #1890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I might have solved the public API in the second commit. Now we should have only |
|
Sorry about the slow turnaround @srogovtsev, I'll be able to loop back to this soon! |
nblumhardt
reviewed
May 3, 2023
| public LoggerConfiguration Logger( | ||
| ILogger logger, | ||
| bool attemptDispose = false, | ||
| LogEventLevel restrictedToMinimumLevel = LevelAlias.Minimum) |
There was a problem hiding this comment.
Sink configuration functions with restrictedToMinimumLevel should now also usually have LevelSwitch support; since this is a new signature, we can tack the extra parameter on without breakage before 3.0, so I'll follow up with a PR for that :-)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1447: we can simply proxy a parameter to
SecondaryLoggerSinkto make this work.The one thing I'm not so sure here is related to the public API change. I've decided to add a new overload method so that the older
WriteTo.Logger(logger, restrictedToMinimumLevel)wouldn't break, but maybe I'm missing something less evident (or more preferable) here.