Make Alignment and LevelOverride readonly #1884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nblumhardt
approved these changes
Mar 28, 2023
| @@ -32,7 +32,7 @@ public sealed class PropertyToken : MessageTemplateToken | |||
| /// <param name="startIndex">The token's start index in the template.</param> | |||
| /// <exception cref="ArgumentNullException">When <paramref name="propertyName"/> is <code>null</code></exception> | |||
| /// <exception cref="ArgumentNullException">When <paramref name="rawText"/> is <code>null</code></exception> | |||
| public PropertyToken(string propertyName, string rawText, string? format = null, Alignment? alignment = null, Destructuring destructuring = Destructuring.Default, int startIndex = -1) | |||
| public PropertyToken(string propertyName, string rawText, string? format = null, in Alignment? alignment = null, Destructuring destructuring = Destructuring.Default, int startIndex = -1) | |||
There was a problem hiding this comment.
This one would be a binary breaking change (see dotnet/docs#3717 (comment)), but given that it's very unlikely to be called by sink code or otherwise, it could be in the "test and revert if necessary during beta" category.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.