Skip to content

Use correct overload with char in JsonFormatter #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2023
Merged

Use correct overload with char in JsonFormatter #1842

merged 1 commit into from
Jan 30, 2023

Conversation

sungam3r
Copy link
Contributor

Also get rid of string.Format in WriteRenderings and WriteProperties.

@SimonCropp
Copy link
Contributor

are there no tests for this code path?

@sungam3r
Copy link
Contributor Author

I don't know. I just reviewed changes from #1839 .

@SimonCropp SimonCropp merged commit 0cd7bb6 into serilog:dev Jan 30, 2023
@sungam3r sungam3r deleted the char branch January 30, 2023 20:26
@nblumhardt nblumhardt mentioned this pull request Jun 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@SimonCropp SimonCropp SimonCropp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sungam3r @SimonCropp