Skip to content

Simplify reflection in SettingValueConversions #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 25, 2023
Merged

Simplify reflection in SettingValueConversions #1814

merged 3 commits into from
Jan 25, 2023

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Jan 25, 2023 •
edited
Loading

  • better perf and simpler code by using binding flags instead of Declared*
  • simplify through removal of typeinfo (typeinfo no longer need since our removal of older netstandards)

@SimonCropp SimonCropp added this to the 3.0.0 milestone Jan 25, 2023
@SimonCropp SimonCropp changed the title simplify reflection in SurrogateConfigurationMethods simplify reflection in SettingValueConversions Jan 25, 2023
@nblumhardt nblumhardt merged commit 8dc64c5 into dev Jan 25, 2023
@nblumhardt nblumhardt deleted the simplify-reflection-in-SurrogateConfigurationMethods branch January 26, 2023 22:25
@SimonCropp SimonCropp changed the title simplify reflection in SettingValueConversions Simplify reflection in SettingValueConversions Jan 27, 2023
@nblumhardt nblumhardt mentioned this pull request Jun 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sungam3r sungam3r sungam3r approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonCropp @sungam3r @nblumhardt