Skip to content

Improve GetPropertiesRecursive performance #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 25, 2023
Merged

Improve GetPropertiesRecursive performance #1813

merged 4 commits into from
Jan 25, 2023

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Jan 25, 2023 •
edited
Loading

  • removes a nested loop
  • removes a lambda allocation
  • remove the use of typeinfo. we no longer need it. means we can use bindingflags (which DeclaredProperties uses internally anyway) but can specify flags we want and remove some extra checks
  • use FlattenHierarchy to avoid the basetype hierarchy walk

@SimonCropp SimonCropp added this to the 3.0.0 milestone Jan 25, 2023
@nblumhardt nblumhardt merged commit 580c55f into dev Jan 25, 2023
@nblumhardt nblumhardt deleted the improve-GetPropertiesRecursive branch January 26, 2023 22:25
@SimonCropp SimonCropp changed the title improve GetPropertiesRecursive Improve GetPropertiesRecursive performance Jan 27, 2023
@nblumhardt nblumhardt mentioned this pull request Jun 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonCropp @nblumhardt