Skip to content

Attempt 4 at SDK 7 #1806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 25, 2023
Merged

Attempt 4 at SDK 7 #1806

merged 8 commits into from
Jan 25, 2023

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Jan 24, 2023 •
edited
Loading

  • installs SDK in appveyor.yml
  • targets net7 in serilog.csproj
  • tests net7
  • remove sdk list in build scrips, since we are installing it explicitly

@SimonCropp SimonCropp changed the title try sdk install in appveyor yml sdk install in appveyor yml Jan 24, 2023
@SimonCropp SimonCropp marked this pull request as draft January 24, 2023 06:30
@SimonCropp SimonCropp changed the title sdk install in appveyor yml Attempt 4 at SDK 7 Jan 24, 2023
@SimonCropp SimonCropp marked this pull request as ready for review January 24, 2023 06:36
@SimonCropp
Copy link
Contributor Author

@sungam3r @nblumhardt this one is good to go, and replaces #1784

@SimonCropp SimonCropp mentioned this pull request Jan 24, 2023
Closed
sungam3r
sungam3r reviewed Jan 24, 2023
View reviewed changes
@SimonCropp
Copy link
Contributor Author

conflict resolved

@SimonCropp SimonCropp merged commit 28f6ba8 into dev Jan 25, 2023
@SimonCropp SimonCropp deleted the try-sdk-install-in-appveyor-yml branch January 25, 2023 01:25
@augustoproiete augustoproiete mentioned this pull request Jan 25, 2023
Closed
@sungam3r sungam3r mentioned this pull request Jan 31, 2023
Merged
@nblumhardt nblumhardt mentioned this pull request Jun 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nblumhardt nblumhardt nblumhardt left review comments

+1 more reviewer

@sungam3r sungam3r sungam3r left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonCropp @nblumhardt @sungam3r