Add API approval test #1783
Merged
Add API approval test #1783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustoproiete
requested changes
Dec 4, 2022
There was a problem hiding this comment.
Thanks @sungam3r
Overal LGTM.
I believe the Serilog.received.txt file created during the test execution should be excluded from source control in .gitignore. Eg.:
*.received.*
Also, the Serilog.verified.txt should have eol set to lf in .gitattributes for consistency across different git setups. Eg.:
*.verified.txt text eol=lf
Co-authored-by: C. Augusto Proiete <augusto@proiete.com>
augustoproiete
approved these changes
Dec 4, 2022
SimonCropp
approved these changes
Dec 5, 2022
|
this LGTM. but i will defer to the core serilog peeps to do the merge |
|
Love it! 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps to verify changes in public API in incoming PRs.